Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][Format] Add internal id column to vertex payload file #264

Merged
merged 11 commits into from
Nov 9, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Oct 25, 2023

Proposed changes

as title

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@acezen acezen force-pushed the 231-add-internal-id-to-payload-file branch from f01245b to ce9daf3 Compare November 6, 2023 06:35
@acezen acezen marked this pull request as ready for review November 6, 2023 09:43
@acezen
Copy link
Contributor Author

acezen commented Nov 6, 2023

cc/ @lixueclaire , this PR needs your review.

@lixueclaire
Copy link
Contributor

cc/ @lixueclaire , this PR needs your review.

Since this is a major change, I will carefully review it shortly afterward.

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ Can you help to update the documentation (like file format figures and api references) as well?

README.rst Outdated Show resolved Hide resolved
docs/user-guide/file-format.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@Ziy1-Tan Ziy1-Tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acezen acezen force-pushed the 231-add-internal-id-to-payload-file branch from 11fc392 to 6444957 Compare November 9, 2023 02:13
@acezen acezen force-pushed the 231-add-internal-id-to-payload-file branch from ed96f9c to acd8d5b Compare November 9, 2023 02:23
@acezen acezen merged commit 77f547a into apache:main Nov 9, 2023
4 checks passed
@acezen acezen deleted the 231-add-internal-id-to-payload-file branch November 9, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants