Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Make the curl interface private #146

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Apr 24, 2023

Proposed changes

Make the curl interface private to fix the issue that other systems integrate GraphAr need to find CURL

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@acezen acezen requested a review from lixueclaire April 24, 2023 09:27
@github-actions
Copy link

github-actions bot commented Apr 24, 2023

🎊 PR Preview 2309ed3 has been successfully built and deployed to https://alibaba-graphar-build-pr-146.surge.sh

🤖 By surge-preview

Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit dc9cd98 into apache:main Apr 24, 2023
@acezen acezen deleted the minor-fix-cmake branch April 24, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants