Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][C++] Improve the usability of EdgesCollection #133

Merged
merged 5 commits into from
Apr 14, 2023

Conversation

lixueclaire
Copy link
Contributor

Proposed changes

This PR improves the usability of EdgesCollection by:

  • support to construct the EdgesCollection for a range of vertex chunks
  • support to get the number of edges in a EdgesCollection

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

related to issue #130 & issue #78

@github-actions
Copy link

github-actions bot commented Apr 11, 2023

🎊 PR Preview b5a4f4a has been successfully built and deployed to https://alibaba-graphar-build-pr-133.surge.sh

🤖 By surge-preview

@lixueclaire lixueclaire changed the title [WIP][Improvement][C++] Improve the usability of EdgesCollection [Improvement][C++] Improve the usability of EdgesCollection Apr 13, 2023
@lixueclaire lixueclaire requested a review from acezen April 13, 2023 08:31
cpp/include/gar/graph.h Outdated Show resolved Hide resolved
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@lixueclaire lixueclaire merged commit 1d2257f into apache:main Apr 14, 2023
@lixueclaire lixueclaire deleted the 130-edge-number branch April 14, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants