-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][Spark] Provide APIs for data reading and writing at the graph level #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 PR Preview 4789ae6 has been successfully built and deployed to https://alibaba-graphar-build-pr-114.surge.sh 🤖 By surge-preview |
acezen
force-pushed
the
88-graph-level-reader-writer
branch
from
March 1, 2023 05:13
f220012
to
b86cda2
Compare
acezen
changed the title
[WIP] Provide API for loading and writing graph
[Improvement][Spark] Provide APIs for data reading and writing at the graph level
Mar 1, 2023
lixueclaire
reviewed
Mar 1, 2023
lixueclaire
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~ It's better to fix the format of annotations.
spark/src/main/scala/com/alibaba/graphar/graph/GraphWriter.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/com/alibaba/graphar/graph/GraphReader.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/com/alibaba/graphar/graph/GraphReader.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/com/alibaba/graphar/graph/GraphWriter.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds
GraphReader
andGraphWriter
for the data reading and writing at the graph level. The methods can help the users to loading or writing graphs through specifying yaml paths or GraphInfo objects of the graphs.This change also revises the GraphInfo to store the vertex infos and edge infos.
Types of changes
What types of changes does your code introduce to GraphAr?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
related issue: #88