Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Spark] Provide APIs for data reading and writing at the graph level #114

Merged
merged 9 commits into from
Mar 1, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Feb 28, 2023

Proposed changes

  • This change adds GraphReader and GraphWriter for the data reading and writing at the graph level. The methods can help the users to loading or writing graphs through specifying yaml paths or GraphInfo objects of the graphs.

  • This change also revises the GraphInfo to store the vertex infos and edge infos.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

related issue: #88

@github-actions
Copy link

github-actions bot commented Feb 28, 2023

🎊 PR Preview 4789ae6 has been successfully built and deployed to https://alibaba-graphar-build-pr-114.surge.sh

🤖 By surge-preview

@acezen acezen force-pushed the 88-graph-level-reader-writer branch from f220012 to b86cda2 Compare March 1, 2023 05:13
@acezen acezen changed the title [WIP] Provide API for loading and writing graph [Improvement][Spark] Provide APIs for data reading and writing at the graph level Mar 1, 2023
@acezen acezen marked this pull request as ready for review March 1, 2023 06:37
@acezen acezen requested a review from lixueclaire March 1, 2023 06:38
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ It's better to fix the format of annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants