[VL] Clean up duplicate CMake code for setting CMAKE_CXX_FLAGS #8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
@PHILO-HE please take a look, I saw that my old PR was already merged before I could apply your suggestion of moving the common code to the top level CMakeLists.txt, I have done the cleanup in this PR. Thanks! |
PHILO-HE
changed the title
PHILO-HE
pushed a commit
to PHILO-HE/gluten
that referenced
this pull request
Nov 28, 2024
PHILO-HE
added a commit
that referenced
this pull request
Nov 28, 2024
…or fixing GHA failure on centos-7 (#8075)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR cleans up duplicate code in cpp/velox and cpp/core CMakeLists.txt and moves them to the top level common CMakeLists.txt
How was this patch tested?
Local Build