[GLUTEN-7850][VL] native writer support CreateHiveTableAsSelectCommand #7851
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jackylee-ch |
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
reviewed
Nov 7, 2024
| @@ -176,4 +176,13 @@ class VeloxParquetWriteForHiveSuite extends GlutenQueryTest with SQLTestUtils { | |||
| checkAnswer(sql("SELECT * FROM t"), Row(1)) | |||
| } | |||
| } | |||
|
|
|||
| test("native writer support CreateHiveTableAsSelectCommand") { | |||
| withTable("t", "t2") { | |||
There was a problem hiding this comment.
t2 is not used in the test, it should be removed.
BTW, create table stored as orc should also be needed in this test.
There was a problem hiding this comment.
removed, this VeloxParquetWriteForHiveSuite suite is specifically for Parquet, and the code paths for ORC and Parquet are consistent.
yikf
force-pushed
the
CreateHiveTableAsSelectCommand
branch
from
780e8f4
to
e5c7f1c
Compare
|
Run Gluten Clickhouse CI on x86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#7850
How was this patch tested?
unit tests