[GLUTEN-7751][VL] Velox backend support merge two aggregate to one complete mode aggregate #7752
+2,535
−2,536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
@yikf can you please also check if |
jackylee-ch
reviewed
Nov 1, 2024
backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala
Show resolved
Hide resolved
|
Glad to see we can learn each other from different backends. It's one of our goal to support different backends in Gluten. |
zzcclp
reviewed
Nov 1, 2024
...it/src/main/scala/org/apache/gluten/extension/columnar/MergeTwoPhasesHashBaseAggregate.scala
Show resolved
Hide resolved
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
weixiuli
reviewed
Nov 7, 2024
|
Run Gluten Clickhouse CI on x86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix #7751.
In issue #4668, support for the CH backend's merge agg capability was added. We can also support this feature in the velox backend.
How was this patch tested?
Through existing unit tests and GA verification, and additional new unit tests have been added.