-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Deprecate memory over-acquiring #7384
base: main
Are you sure you want to change the base?
Conversation
Run Gluten Clickhouse CI |
Q97 OOM test is failing when turning over-acquire off, should investigate link: log:
|
The root cause should be that: Velox estimates and reserves some memory before real allocation, but the reserved memory size is too small. |
Run Gluten Clickhouse CI on x86 |
Run Gluten Clickhouse CI on x86 |
As Velox is getting stabler on spill-to-disk, we will start to remove memory over-acquiring (introduced since #2321) to improve Gluten's memory utilization.
This is the part one to set over-acquire ratio to 0.