[VL] Add shuffle writer type to ColumnarExchange display string #6799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
| if (useSortBasedShuffle) GlutenConfig.GLUTEN_SORT_SHUFFLE_WRITER | ||
| else GlutenConfig.GLUTEN_HASH_SHUFFLE_WRITER | ||
| } | ||
| super.stringArgs ++ Iterator(s"$shuffleWriterType") |
There was a problem hiding this comment.
Can we use [shuffle_writer_type=$shuffleWriterType] instead?
And does shuffleWriterType is always lower case, it should be consistent
|
Thanks! Just a little nit. |
|
Run Gluten Clickhouse CI |
marin-ma
force-pushed
the
columnar-exchange-str
branch
from
7aa6ca3
to
501ba09
Compare
|
Run Gluten Clickhouse CI |
| if (useSortBasedShuffle) GlutenConfig.GLUTEN_SORT_SHUFFLE_WRITER | ||
| else GlutenConfig.GLUTEN_HASH_SHUFFLE_WRITER | ||
| } | ||
| super.stringArgs ++ Iterator(s"[shuffle_writer_type=$shuffleWriterType]") |
There was a problem hiding this comment.
You may also need to update the tpch-approved-plan
|
Run Gluten Clickhouse CI |
jinchengchenghh
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To distinguish between the hash and sort shuffle writer types more clearly, add "hash" or "sort" to the operator's display string, and remove
[id=#$id]as it's the same as[plan_id=#$id]inExchange