Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-5499][VL] Enable HighOrderFunctionSuites #5505

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

Yohahaha
Copy link
Contributor

@Yohahaha Yohahaha commented Apr 23, 2024

Fixes #5499

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

@FelixYBW
Copy link
Contributor

What does the suite test?

Copy link

Run Gluten Clickhouse CI

@Yohahaha
Copy link
Contributor Author

What does the suite test?

#5410 (review)

for array_transform, array_filter etc.

@Yohahaha Yohahaha changed the title [VL] Enable HighOrderFunctionSuites [GLUTEN-5499][VL] Enable HighOrderFunctionSuites Apr 24, 2024
Copy link

#5499

@Yohahaha Yohahaha requested a review from PHILO-HE April 24, 2024 02:34
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks so much!

@Yohahaha Yohahaha merged commit 45dc46a into apache:main Apr 24, 2024
41 checks passed
@Yohahaha Yohahaha deleted the enable-highorderfuncsuite branch April 24, 2024 04:57
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5505_time.csv log/native_master_04_23_2024_fd2519a2b_time.csv difference percentage
q1 35.41 36.36 0.947 102.67%
q2 27.44 24.01 -3.434 87.49%
q3 35.75 36.90 1.156 103.23%
q4 41.36 39.08 -2.284 94.48%
q5 70.21 69.94 -0.269 99.62%
q6 7.49 7.58 0.082 101.09%
q7 85.63 86.14 0.507 100.59%
q8 86.43 85.13 -1.309 98.49%
q9 119.37 122.27 2.897 102.43%
q10 43.78 43.15 -0.621 98.58%
q11 21.15 21.01 -0.143 99.32%
q12 27.67 27.87 0.192 100.70%
q13 57.76 55.25 -2.505 95.66%
q14 18.02 20.45 2.425 113.45%
q15 31.30 28.88 -2.419 92.27%
q16 14.31 14.54 0.234 101.63%
q17 104.33 106.73 2.400 102.30%
q18 145.41 147.26 1.842 101.27%
q19 13.73 13.90 0.171 101.25%
q20 29.49 28.89 -0.595 97.98%
q21 291.24 295.12 3.880 101.33%
q22 14.62 17.71 3.085 121.10%
total 1321.92 1328.16 6.237 100.47%

Preetesh2110 pushed a commit to Preetesh2110/incubator-gluten that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Enable HigherOrderFunctionsSuite
4 participants