feat: insert tests for some domain level DB models - WIP #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking this over for today. We can pair again on it when you get back tomorrow my dude @kevin-kline |
joncodo
force-pushed
the
kk-migrations
branch
from
7c45cee to
bc29dfe
Compare
…ations in the new PR
joncodo
force-pushed
the
kk-migrations
branch
from
bc29dfe to
42b9802
Compare
mamh2021
pushed a commit
to golang108/merico-dev-lake
that referenced
this pull request
Apr 10, 2022
feat: insert tests for some domain level DB models - WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a WIP PR.
The purpose is to create tests on all our DB models prior to our migrations refactor in ticket #806
This is step 1.
We will run the tests again AFTER the refactor to make sure all models behave as expected.
Does this close any open issues?
Relates to: https://github.com/merico-dev/lake/issues/972
Other Information