Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update change lead time details dashboard #8179

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: update change lead time details dashboard #8179

merged 1 commit into from
Nov 1, 2024

Conversation

Startrekzky
Copy link
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

  1. Fix the time filter, so that when the time range is within 1 month, the dashboard also shows the stats.
  2. Fix the key to filter PR from pr_created_date to pr_deployed_date to make it consistent with the condition of the pr table below.
  3. Update the dashboard intro.

Screenshots

image

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 1, 2024
@Startrekzky Startrekzky requested a review from klesh November 1, 2024 10:15
@dosubot dosubot bot added component/ext This issue or PR relates to external components, such as Grafana needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident labels Nov 1, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 1, 2024
@d4x1 d4x1 merged commit 5cd96a1 into apache:main Nov 1, 2024
13 checks passed
@Startrekzky Startrekzky deleted the fix-lead-time-details branch November 1, 2024 11:03
Startrekzky added a commit to merico-dev/lake that referenced this pull request Nov 1, 2024
@Startrekzky @merico-devlake
fix: update change lead time details dashboard (apache#8179)
a62988b
@Startrekzky Startrekzky mentioned this pull request Nov 1, 2024
Merged
4 tasks
klesh pushed a commit that referenced this pull request Nov 1, 2024
@Startrekzky @merico-devlake
cherry-pick #8114 #8179 Fix DORA and lead time for changes details da…
83ec4a5 
…shboards (#8180)

* fix: improve the time filters in DORA dashboards (#8114)

Co-authored-by: Startrekzky <[email protected]>

* fix: update change lead time details dashboard (#8179)

---------

Co-authored-by: Startrekzky <[email protected]>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4x1 d4x1 d4x1 approved these changes

@klesh klesh Awaiting requested review from klesh

Assignees
No one assigned
Labels
component/ext This issue or PR relates to external components, such as Grafana lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Startrekzky @d4x1 @merico-devlake