Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check pipelines' tokens before executing/creating pipeline #8055

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Sep 14, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Check tokens before creating pipelines
  2. Restranform will succeed regardless of whether the tokens are legal or not

Does this close any open issues?

Related #8017

Screenshots

Include any relevant screenshots here.

Github

Collect data with wrong token

image

restransform can be executed successfully

image

Collect Data In Full Refresh Mode

image

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature labels Sep 14, 2024
@d4x1
Copy link
Contributor Author

d4x1 commented Sep 14, 2024

  • There are some problems with GitHub connection, I am still working on it.

GitHub connection with multi tokens, one is valid, the other is invalid.

image

In its project, when user click "Collect Data", pipeline won't be created.

image

@d4x1 d4x1 changed the base branch from main to feat-8017 September 19, 2024 04:13
@d4x1 d4x1 merged commit 49caa2a into feat-8017 Sep 19, 2024
10 checks passed
@d4x1 d4x1 deleted the dev-1 branch September 19, 2024 04:13
mintsweet pushed a commit that referenced this pull request Sep 26, 2024
* feat(pipeline): check pipelines' tokens before executing/creating pipeline

* fix(framework): fix lint errors

* fix(framework): fix lint errors

* feat(github): check multi tokens when creating pipelines
mintsweet pushed a commit that referenced this pull request Sep 29, 2024
* feat(pipeline): check pipelines' tokens before executing/creating pipeline

* fix(framework): fix lint errors

* fix(framework): fix lint errors

* feat(github): check multi tokens when creating pipelines
mintsweet added a commit that referenced this pull request Sep 30, 2024
…) (#8069)

* feat: check pipelines' tokens before executing/creating pipeline (#8055)

* feat(pipeline): check pipelines' tokens before executing/creating pipeline

* fix(framework): fix lint errors

* fix(framework): fix lint errors

* feat(github): check multi tokens when creating pipelines

* feat(project): add token check result in project check API (#8099)

* Dev 1 (#8100)

* feat(project): add token check result in project check API

* feat(project): update token check API response

* Dev 1 (#8101)

* feat(project): add token check result in project check API

* feat(project): update token check API response

* fix(project): fix api doc

* fix(project): update project check api doc

* fix(project): update check project api doc

* feat: add connection token check before collect data

* feat(blueprint): add new api to check connection tokens (#8102)

* fix: adjust the api for connections token check

* feat: add a component connection-form-modal

* feat: add a component connection-name

* fix: show connection form modal when connection token check failed

* refactor: improve the component connection-name

* fix: error check connection token failed list

* refactor: extract the function in the panel to bp detail

* fix: not call onCancel function when updating connection

* fix: search local items error

---------

Co-authored-by: mintsweet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant