Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github\gitlab): doesn't init api client when re-transformating #7966

Merged
merged 16 commits into from
Sep 6, 2024
Merged

feat(github\gitlab): doesn't init api client when re-transformating #7966

merged 16 commits into from
Sep 6, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Aug 27, 2024 •
edited
Loading

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
Doesn't init api client when re-transformating

Does this close any open issues?

Closes #8004
Related #8017

Screenshots

Include any relevant screenshots here.

restransformation with new codes

image

no internet connection, it can still work

image

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 marked this pull request as ready for review August 27, 2024 09:24
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 27, 2024
@d4x1 d4x1 added the pr-type/feature-development This PR is to develop a new feature label Aug 27, 2024
@dosubot dosubot bot added the component/plugins This issue or PR relates to plugins label Aug 27, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 2, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Sep 2, 2024
@d4x1
Copy link
Contributor Author

d4x1 commented Sep 5, 2024

I hope it should be merged into v1.1.0 if possiable.

@d4x1
Copy link
Contributor Author

d4x1 commented Sep 5, 2024

There is a remaing task: try to re-transformate data without any internet connection.

@d4x1 d4x1 changed the title feat(github): doesn't init api client when re-transformating feat(github\gitlab): doesn't init api client when re-transformating Sep 6, 2024
@d4x1
Copy link
Contributor Author

d4x1 commented Sep 6, 2024

It works in gitlab too
image

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 6, 2024
@d4x1 d4x1 merged commit fde073a into main Sep 6, 2024
11 checks passed
@d4x1 d4x1 deleted the dev-1 branch September 6, 2024 08:37
@d4x1
Copy link
Contributor Author

d4x1 commented Sep 6, 2024

There is a remaing task: try to re-transformate data without any internet connection.

solved.

This was referenced Sep 6, 2024
Merged
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/feature-development This PR is to develop a new feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@d4x1 @klesh @abeizn @mintsweet @Startrekzky