Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): use incident tables in dashboards #7798

Merged
merged 5 commits into from
Jul 31, 2024
Merged

feat(dashboard): use incident tables in dashboards #7798

merged 5 commits into from
Jul 31, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Jul 31, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
Use incident table in dashboards:

  1. dora-detail:change failure rate
  2. dora-detail:failed deployment recovery time
  3. dora-detail:time to restore service

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

dora-detail:change failure rate

Before

image

After

image

dora-detail:failed deployment recovery time

Before

image

After

image

dora-detail:time to restore service

Before

image

After

image

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 self-assigned this Jul 31, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 31, 2024
@dosubot dosubot bot added component/ext This issue or PR relates to external components, such as Grafana pr-type/feature-development This PR is to develop a new feature labels Jul 31, 2024
@d4x1 d4x1 changed the title feat(dashboard): use incident tables in dora-detail:change failure rate feat(dashboard): use incident tables in dashboards Jul 31, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 31, 2024
Copy link
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 31, 2024
@Startrekzky Startrekzky merged commit 2ffac34 into main Jul 31, 2024
8 checks passed
@Startrekzky Startrekzky deleted the dev-1 branch July 31, 2024 10:34
github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
* feat(dashboard): use incident tables in dora-detail:change failure rate

* fix(dashboard): fix sql errors

* feat(dashboard): use incident tables in dora-detail:failed deployment recovery time

* fix(dashboard): dora detail supports table: incidents
Copy link

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jul 31, 2024
d4x1 added a commit that referenced this pull request Jul 31, 2024
* feat(dashboard): use incident tables in dora-detail:change failure rate

* fix(dashboard): fix sql errors

* feat(dashboard): use incident tables in dora-detail:failed deployment recovery time

* fix(dashboard): dora detail supports table: incidents

Co-authored-by: Lynwee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/ext This issue or PR relates to external components, such as Grafana lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/feature-development This PR is to develop a new feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants