fix(helpers): use isIncremental instead of SyncPolicy.FullSync
#7773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
added
the
severity/p2
|
🤖 Target: #release-v1.0 cherry pick finished successfully 🎉! |
github-actions
bot
added
the
bot/auto-cherry-pick-completed
Nickcw6
pushed a commit
to Nickcw6/incubator-devlake
that referenced
this pull request
Jul 23, 2024
abeizn
pushed a commit
that referenced
this pull request
Jul 23, 2024
…7773) (#7774) Co-authored-by: Lynwee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
Use
isIncrementalinstead ofSyncPolicy.FullSync.Var
syncPolicyin code:= args.Ctx.TaskContext().SyncPolicy()comes from_devlake_pipelines.When we collect data, then change its time range, set an early start time, collect data again. It should collect data fully, but
_devlake_pipelines.full_syncis zero, which stands for false. So inNewStatefulApiCollectorForFinalizableEntitywe should useisIncremental.Does this close any open issues?
Closes #7772 #7766.
Maybe related #7739.
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.