Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct path for grafana dockerfile #7628

Merged

Conversation

tim-goto
Copy link
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

fix the grafana dockerfile path

Does this close any open issues?

Screenshots

Other Information

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/ext This issue or PR relates to external components, such as Grafana pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident labels Jun 18, 2024
@tim-goto tim-goto force-pushed the feature/tharing/fix-grafana-dockerfile-path branch from a326901 to 46d5681 Compare June 18, 2024 14:47
@@ -40,7 +40,7 @@ push-config-ui-image: build-config-ui-image
docker push $(IMAGE_REPO)/devlake-config-ui:$(TAG)

push-grafana-image: build-grafana-image
docker push $(IMAGE_REPO)/devlake-dashboard:$(TAG)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was an invalid character here, unfortunately the github webui doesn't show it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, spaces vs tab

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 19, 2024
@klesh klesh merged commit a69ddce into apache:main Jun 19, 2024
11 checks passed
@tim-goto tim-goto deleted the feature/tharing/fix-grafana-dockerfile-path branch June 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ext This issue or PR relates to external components, such as Grafana lgtm This PR has been approved by a maintainer pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants