Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azuredevops): fix environment field in cicd_tasks and cicd_pipelines #7060

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Feb 29, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
environment field in cicd_tasks and cicd_pipelines is a varchar type, but in Python, it's defined with type hint like

environment: Optional[CICDEnvironment]
# CICDEnvironment is an enum class.

If the value you assign to environment is a string, it cannot work as expected.
Otherwise, if environment is defined like

environment: Optional[str]

and you assign it with an enum, it cannot work either.

Does this close any open issues?

Closes N/A.

Screenshots

Include any relevant screenshots here.
With same scope config
image

Before

image #### After image

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 self-assigned this Feb 29, 2024
@abeizn abeizn merged commit d9816d1 into main Feb 29, 2024
12 checks passed
@abeizn abeizn deleted the lw-fix-azure-0229 branch February 29, 2024 08:29
Copy link

🤖 The current file has a conflict, and the pr cannot be automatically created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants