Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): update log message when reading configurations #6969

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Feb 18, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
When users deploy DevLake using helm with some wrong env values such as commonEnvs.TZ=UTC-3 (UTC-3 is illegal), user can see a log time="2024-01-30T17:54:34Z" level=info msg="no [.env] file, please make sure you have set the environment variable.". This log is very misleading and it should be improved.

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 added this to the v1.0 milestone Feb 18, 2024
@d4x1 d4x1 added the pr-type/bug-fix This PR fixes a bug label Feb 18, 2024
@klesh klesh merged commit 8b83fc6 into apache:main Feb 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-type/bug-fix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants