Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumps node to 18 in builder image and actions for config-ui #6884

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

wanisfahmyDE
Copy link
Contributor

@wanisfahmyDE wanisfahmyDE commented Jan 26, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
This PR upgrades the config-ui to node 18 because node 16 deprecated and without active support

Does this close any open issues?

Closes #6885

Screenshots

Include any relevant screenshots here.

Other Information

I built the config-ui ldocker image locally against node 18 and it was successful.

@wanisfahmyDE wanisfahmyDE marked this pull request as ready for review January 26, 2024 14:28
@wanisfahmyDE
Copy link
Contributor Author

hey @Startrekzky, can you maybe have a look?
It's my first PR here, I hope I didn't miss something.
Thanks

Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh
Copy link
Contributor

klesh commented Jan 30, 2024

Thanks for your contribution.

@wanisfahmyDE
Copy link
Contributor Author

thank you @klesh for reviewing 🙏

@klesh klesh merged commit 81e3149 into apache:main Jan 30, 2024
11 checks passed
ViktorGrigorov7 pushed a commit to ViktorGrigorov7/incubator-devlake that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][config-ui] upgrades nodejs to 18
2 participants