-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gitlab) fetch trigger jobs #6167
Conversation
I will merge it after solving the issue #5920 |
LGTM, to be merged after v0.21-beta1 released |
dal.Select("gp.gitlab_id, gp.gitlab_id as iid"), | ||
dal.From("_tool_gitlab_pipelines gp"), | ||
dal.Where( | ||
`gp.project_id = ? and gp.connection_id = ? and gp.gitlab_id not in (select json_extract(tj.input, '$.GitlabId') as gitlab_id from _raw_gitlab_api_trigger_job tj)`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running this SQL, table _raw_gitlab_api_trigger_job
doesn't exist.
@Marco-De-Stefani I encounter a problem when running the latest main branch and the log is
And I think SQL in function |
* feat(gitlab): fetching the "trigger" job as well * feat(gitlab): add test for parsing trigger job
Summary
Add the trigger jobs to the jobs already fetched from GitLab
Does this close any open issues?
Closes #6135
Screenshots
data fetched from a real GitLab instance:
The processing of the data after the collection is tested with the
trigger_job_test.go