Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: azure adapts original_status and status #5143

Merged
merged 3 commits into from
May 10, 2023

Conversation

abeizn
Copy link
Contributor

@abeizn abeizn commented May 10, 2023

Summary

feat: azure adapts original_status and status

Does this close any open issues?

part of #4745

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@abeizn abeizn requested a review from CamilleTeruel May 10, 2023 01:50
@abeizn
Copy link
Contributor Author

abeizn commented May 10, 2023

Hello @CamilleTeruel, Can you help me review my code?

There is also a need to confirm whether the state is correct in this issue(#4745). I see that the state in the issue is inconsistent with the code.
image


yield code.PullRequest(
base_repo_id=base_repo_id,
head_repo_id=repo_id,
status=status,
original_status=original_status,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use original_status=pr.status.value here and remove the added lines above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use original_status=pr.status.value here and remove the added lines above.

@CamilleTeruel updated

@mindlesscloud mindlesscloud merged commit 80ae444 into apache:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants