feat: db migration #1458
Merged
feat: db migration #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindlesscloud
force-pushed
the
db-migration
branch
2 times, most recently
from
c6a0a13 to
58f8750
Compare
klesh
approved these changes
Apr 11, 2022
| "gorm.io/gorm" | ||
| ) | ||
|
|
||
| type Script interface { |
There was a problem hiding this comment.
Script is too general, how about MigrationScript
migration/interface.go
Outdated
| type Script interface { | ||
| Up(ctx context.Context, db *gorm.DB) error | ||
| Version() uint64 | ||
| Owner() string |
There was a problem hiding this comment.
I thought we agree that owner is not needed.
migration/migrator.go
Outdated
| m.db = db | ||
| } | ||
|
|
||
| func (m *migrator) register(scripts ...Script) { |
There was a problem hiding this comment.
Maybe we should pass one more field like comment to declare which plugin they belong to.
and save it into database, to help with debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It provides a tool to keep model definitions and the database schema in sync. All the changes in the schema will be written in the database
Key Points
Description
Describe what this PR does, and aims to solve in a few sentences.
Does this close any open issues?
#1057 #1414 #1304
Current Behavior
Describe the current behaviour of this issue, if relevant.
New Behavior
Describe the new behaviour updated in this issue, if relevant.
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.