feature: ignored upstream nodes with a weight of 0. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonming
requested changes
Sep 18, 2019
|
fixed #532 |
chnliyong
reviewed
Sep 18, 2019
lua/apisix/balancer.lua
Outdated
| if weight > 0 then | ||
| up_nodes[addr] = weight | ||
| end | ||
| end | ||
| return upstream.nodes |
There was a problem hiding this comment.
Here should return up_nodes
There was a problem hiding this comment.
old implementation is enough, it support weight equal 0 case already. we do not need to patch here, I reverted those new code.
chnliyong
reviewed
Sep 18, 2019
lua/apisix/balancer.lua
Outdated
| if weight > 0 then | ||
| up_nodes[addr] = weight | ||
| end | ||
| end | ||
| return upstream.nodes | ||
| end | ||
|
|
||
| local host = upstream.checks and upstream.checks.host | ||
| local up_nodes = core.table.new(0, #upstream.nodes) |
There was a problem hiding this comment.
This statement likely duplicate
moonming
requested changes
Sep 18, 2019
| "127.0.0.1:1980": 1, | ||
| "127.0.0.1:1981": 0, | ||
| "127.0.0.1:1982": 0 | ||
| } |
There was a problem hiding this comment.
need to check the nodes wrote into etcd.
There was a problem hiding this comment.
| "type": "roundrobin", | ||
| "nodes": { | ||
| "127.0.0.1:1980": 3, | ||
| "127.0.0.1:1981": 0, |
There was a problem hiding this comment.
the admin API will return 127.0.0.1:1981 or not? we need add test cases for that.
There was a problem hiding this comment.
current implementation is enough, it supports weight equal 0 now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.