Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need one new fields to disable upstream node? #532

Closed
a610569731 opened this issue Sep 17, 2019 · 5 comments
Closed

Do we need one new fields to disable upstream node? #532

a610569731 opened this issue Sep 17, 2019 · 5 comments
Labels
discuss
Milestone
ver 0.8

Comments

@a610569731
Copy link

a610569731 commented Sep 17, 2019 •
edited by moonming
Loading

需求场景
替换后端代码需要下线其中某个节点,替换后在上线

scenario
upgrading back-end requires one of the nodes to be offline, and then on-line
@membphis
Copy link
Member

membphis commented Sep 17, 2019 •
edited by moonming
Loading

Can we use the special value of weight = 0 to indicate the effect of a specific node being disabled?

Whether it's roundbin or chash, before you start pick server, filter out the node with weight of 0.

@a610569731
Copy link
Author

a610569731 commented Sep 17, 2019 •
edited by moonming
Loading

yes

@membphis
Copy link
Member

membphis commented Sep 17, 2019 •
edited by moonming
Loading

PR is welcomed.
Core code is easy to change, and some difficult estimates are in the test case section.

@moonming moonming changed the title upstream node 需要新增字段是否禁用 Do we need one new fields to disable upstream node? Sep 18, 2019
@a610569731
Copy link
Author

lua 还看不懂哈

@moonming moonming mentioned this issue Sep 18, 2019
Merged
@membphis
Copy link
Member

fixed by #536

@membphis membphis added this to the ver 0.8 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss
Projects
None yet
Milestone
ver 0.8
Development

No branches or pull requests
3 participants
@a610569731 @membphis @moonming