Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add note about running tests/itests on MacOS #8766

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

jbonofre
Copy link
Member

No description provided.

@github-actions github-actions bot added the docs label Oct 10, 2023
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be great if somebody with OSX could confirm this

@ajantha-bhat
Copy link
Member

LGTM, but would be great if somebody with OSX could confirm this

I can confirm. I use MAC. Not just for Iceberg project, any project that uses TestContainers on MAC will throw an error for running tests that "Could not find a valid Docker environment."

I used to google and use the command from below answer. Which matches the doc update.
https://stackoverflow.com/questions/61108655/test-container-test-cases-are-failing-due-to-could-not-find-a-valid-docker-envi

@jbonofre
Copy link
Member Author

@nastra actually it's the workaround I have to do on my Mac :) I'm using MacOS (tested both on 13 & 14 with Docker Desktop) on M1.

@ajantha-bhat ajantha-bhat self-requested a review October 10, 2023 15:57
Copy link
Member

@ajantha-bhat ajantha-bhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also neutral about this change. As it is not a specific problem about Iceberg.

@jbonofre
Copy link
Member Author

@ajantha-bhat I bet we can have questions for any MacOS user trying to build iceberg (it was my case). Even people on Linux should know that Docker is required for the tests. So, this note will help people (including us to answer the same question again and again :) ).

@jbonofre
Copy link
Member Author

@nastra are you OK to merge this one ?

@nastra
Copy link
Contributor

nastra commented Oct 12, 2023

@Fokko could you review and confirm this one please?

@Fokko
Copy link
Contributor

Fokko commented Oct 17, 2023

For me it looks like the file was created by the daemon:

➜  ls -lah /var/run/docker.sock
lrwxr-xr-x  1 root  daemon    46B Oct 16 16:32 /var/run/docker.sock -> /Users/fokkodriesprong/.docker/run/docker.sock
➜  last reboot                         
reboot time                                Mon Oct 16 16:29

(I started docker just after my reboot)

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind adding this, but it looks like that it isn't the same for everyone on Mac

@jbonofre
Copy link
Member Author

@Fokko I think anyone using docker-desktop on Mac will have the same issue. So it applies for 99% of the MacOS users.

@Fokko
Copy link
Contributor

Fokko commented Oct 17, 2023

@jbonofre I'm running docker desktop as well

@Fokko Fokko merged commit cb20bdb into apache:main Oct 17, 2023
2 checks passed
@jbonofre
Copy link
Member Author

@Fokko and you don't have the symbolic link ? Did you install docker-desktop from homebrew cask ?

@jbonofre jbonofre deleted the TEST_ON_MAC branch January 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants