-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Add note about running tests/itests on MacOS #8766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be great if somebody with OSX could confirm this
I can confirm. I use MAC. Not just for Iceberg project, any project that uses I used to google and use the command from below answer. Which matches the doc update. |
@nastra actually it's the workaround I have to do on my Mac :) I'm using MacOS (tested both on 13 & 14 with Docker Desktop) on M1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also neutral about this change. As it is not a specific problem about Iceberg.
@ajantha-bhat I bet we can have questions for any MacOS user trying to build iceberg (it was my case). Even people on Linux should know that Docker is required for the tests. So, this note will help people (including us to answer the same question again and again :) ). |
@nastra are you OK to merge this one ? |
@Fokko could you review and confirm this one please? |
For me it looks like the file was created by the daemon:
(I started docker just after my reboot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind adding this, but it looks like that it isn't the same for everyone on Mac
@Fokko I think anyone using docker-desktop on Mac will have the same issue. So it applies for 99% of the MacOS users. |
@jbonofre I'm running docker desktop as well |
@Fokko and you don't have the symbolic link ? Did you install docker-desktop from homebrew cask ? |
No description provided.