Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Accept all API warnings in master #4770

Merged
merged 1 commit into from
May 15, 2022

Conversation

kbendick
Copy link
Contributor

Adds a blanket acceptance for all existing breaks that occurred prior to the introduction of the API / ABI compatibility guarantee checking tool, revapi, in #4638

cc @rdblue

@kbendick kbendick force-pushed the accepted-preexisting-abi-breaks branch from 05eda51 to 84cabe5 Compare May 14, 2022 19:30
@rdblue rdblue changed the title Core - Accept all API / ABI breaks prior to introducing compatibility checking Core: Accept all API warnings in master May 14, 2022
@rdblue
Copy link
Contributor

rdblue commented May 14, 2022

This looks good since there are only 2 warning types: defaultSerializationChanged and addedToInterface. The serialization changes are for classes without serialVersionUID, but Iceberg does not guarantee any compatibility for serialized objects across versions. The interface additions are also fine because these interfaces are for internal implementations. Adding methods does not break binary compatibility for people using the interfaces.

@kbendick
Copy link
Contributor Author

This looks good since there are only 2 warning types: defaultSerializationChanged and addedToInterface. The serialization changes are for classes without serialVersionUID, but Iceberg does not guarantee any compatibility for serialized objects across versions. The interface additions are also fine because these interfaces are for internal implementations. Adding methods does not break binary compatibility for people using the interfaces.

We can be more specific for the changes (provide a justification for each or for generally that class of error - like methods added to interfaces is something I hope to suppress). But for now this will unblock 😄

@rdblue rdblue merged commit 37cc621 into apache:master May 15, 2022
@rdblue
Copy link
Contributor

rdblue commented May 15, 2022

Thanks, @kbendick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants