Add fallback
attribute to all strip_option
s.
#708
+11
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-derived
TypedBuilder
traits in combination withstrip_option
attributes are very hard to use in scenarios where options passed to the builder depend on user input. The problem is that this pattern doesn't work, since the two match branches return different types:Fortunately typed_builder 0.20 supports an additional attribute (
fallback
) that generates a builder method that takesOption<T>
in addition to the method that takes nakedT
.With this attribute, we can write
let builder = builder.x_opt(x)
.This commit adds the
fallback
attribute to all fields that have thestrip_option
annotation.