[Bug Fix] HiveCatalog's _commit_table need to refresh and update the metadata in a transaction #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HonahX Thanks for fixing this. I think we should backport this to 0.6.1 as well 👍 |
HonahX
added a commit
to HonahX/iceberg-python
that referenced
this pull request
Apr 16, 2024
…thin transaction (apache#607) * make refresh and update metadata in a transaction * fix integration tests
HonahX
added a commit
that referenced
this pull request
Apr 16, 2024
…thin transaction (#607) * make refresh and update metadata in a transaction * fix integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #588
Hive's
alter_tabledoes not support transactional check unless https://issues.apache.org/jira/browse/HIVE-26882 is included. Hence, we need to load and update the metadata within the lock (in a transaction) to ensure consistency