Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typealias for table version #566

Merged
merged 7 commits into from
Apr 3, 2024
Merged

typealias for table version #566

merged 7 commits into from
Apr 3, 2024

Conversation

MehulBatra
Copy link
Contributor

Create TypeAlias for the version method return, to ensure the type safety, readability & maintainability.

Fokko
Fokko reviewed Mar 31, 2024
View reviewed changes
pyiceberg/typedef.py Outdated Show resolved Hide resolved
@MehulBatra MehulBatra requested a review from Fokko April 1, 2024 06:26
Fokko
Fokko approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @MehulBatra 🙌

@Fokko Fokko merged commit ba9ff98 into apache:main Apr 3, 2024
7 checks passed
@MehulBatra
Copy link
Contributor Author

Thanks for working on this @MehulBatra 🙌

Always great to work on Iceberg and learn from you and the team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MehulBatra @Fokko