Make scope configurable #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Feb 29, 2024
There was a problem hiding this comment.
Thanks for working on this @himadripal. Can you fix the conflicts? Thanks!
Fokko
approved these changes
Feb 29, 2024
|
@Fokko Thank you for the approval. Fixed the conflict, can you please let the build checks run? |
|
The easiest way is to fix this locally using |
@Fokko Thank you for this tip. |
|
locally all passed (venv) % poetry run pre-commit run --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check docstring is first.................................................Passed
debug statements (python)................................................Passed
check yaml...............................................................Passed
check python ast.........................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Passed
mypy.....................................................................Passed
pycln....................................................................Passed
mdformat.................................................................Passed
pydocstyle...............................................................Passed
flynt....................................................................Passed@Fokko Can you rerun the build check please? |
himadripal
force-pushed
the
make_scope_configurable
branch
from
adfdea2 to
e508a9f
Compare
added scope as configurable option, defaults to `CATALOG_SCOPE` resolve conflicts. change to constant style fix
himadripal
force-pushed
the
make_scope_configurable
branch
from
01f6541 to
f9635a6
Compare
Fokko
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Looks good. Could you also create a PR to update the documentation:
iceberg-python/mkdocs/docs/configuration.md
Line 152 in 36b56eb
flyrain
approved these changes
Mar 5, 2024
Fokko
approved these changes
Mar 5, 2024
|
Thanks for working on this @himadripal and for the review @flyrain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#462