Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstring: Fix missing commit #432

Merged
merged 1 commit into from
Feb 21, 2024
Merged

docstring: Fix missing commit #432

merged 1 commit into from
Feb 21, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 15, 2024

While going through some code, I noticed that these are missing

@kevinjqliu
Copy link
Contributor

I wonder if there's a tool to do static analysis and add these automatically

@Fokko
Copy link
Contributor Author

Fokko commented Feb 19, 2024

@kevinjqliu I would love that. I searched for that in the past but the tooling was quite thin at the time.

Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

@HonahX HonahX merged commit 44948cd into apache:main Feb 21, 2024
6 checks passed
@HonahX HonahX added this to the PyIceberg 0.6.1 milestone Mar 27, 2024
HonahX pushed a commit to HonahX/iceberg-python that referenced this pull request Mar 28, 2024
HonahX pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants