Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable parsing #423

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 13, 2024

Reported on Slack: https://apache-iceberg.slack.com/archives/C029EE6HQ5D/p1707633685716559

export PYICEBERG_CATALOG__SOMETHING__S3__REGION=eu-north-1

Before:

>>> from pyiceberg.catalog import load_catalog
>>> load_catalog('something').properties
{'s3': {'region': 'eu-north-1'}, ...}

After:

>>> from pyiceberg.catalog import load_catalog
>>> load_catalog('something').properties
{'s3.region': 'eu-north-1', ...}

Which correspondents with the key s3.region that we use. Now the example makes sense:

image

```bash
export PYICEBERG_CATALOG__SOMETHING__S3__REGION=eu-north-1
```

Before:

```python
>>> from pyiceberg.catalog import load_catalog
>>> load_catalog('something').properties
{'s3': {'region': 'eu-north-1'}, ...}
```

After:

```python
>>> from pyiceberg.catalog import load_catalog
>>> load_catalog('something').properties
{'s3.region': 'eu-north-1', ...}
```

Which correspondents with the key `s3.region` that we use.
@Fokko Fokko added this to the PyIceberg 0.6.0 release milestone Feb 13, 2024
Fokko and others added 2 commits February 14, 2024 00:03
Co-authored-by: Hussein Awala <[email protected]>
@Fokko Fokko merged commit cc44926 into apache:main Feb 14, 2024
6 checks passed
@Fokko Fokko deleted the fd-fix-configuration branch February 14, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants