Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump 3rd party deps #1454

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Build: Bump 3rd party deps #1454

merged 4 commits into from
Dec 22, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 20, 2024

This bumps all 3rd party dependencies to the latest. Trying to unblock #1377.

Dependabot only updates the packages that we directly rely on. It can be that indirect dependencies are bumped, but we haven't updated yet.

@Fokko
Copy link
Contributor Author

Fokko commented Dec 21, 2024

Ray does not yet support Numpy 2.x

@Fokko Fokko requested a review from kevinjqliu December 21, 2024 20:13
@@ -1,4 +1,4 @@
# This file is automatically @generated by Poetry 1.8.5 and should not be changed by hand.
# This file is automatically @generated by Poetry 1.8.3 and should not be changed by hand.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you need to run make install again to get the latest poetry version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, since I have poetry installed, it will just skip over it:

iceberg-python/Makefile

Lines 22 to 28 in 325c8a5

install-poetry: ## Install poetry if the user has not done that yet.
@if ! command -v poetry &> /dev/null; then \
echo "Poetry could not be found. Installing..."; \
pip install --user poetry==1.8.5; \
else \
echo "Poetry is already installed."; \
fi

@Fokko Fokko merged commit 9f47077 into apache:main Dec 22, 2024
7 checks passed
@Fokko Fokko deleted the fd-bump-deps branch December 22, 2024 20:34
@Fokko
Copy link
Contributor Author

Fokko commented Dec 22, 2024

Tnx for the quick review @kevinjqliu 🙌

sungwy pushed a commit to sungwy/iceberg-python that referenced this pull request Dec 24, 2024
* Build: Bump 3rd party deps

* Set numpy at <2.x

* Fix numpy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants