[HUDI-8295] validate utilities bundle with spark #12287
Open
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linliu-code
reviewed
Nov 20, 2024
| else | ||
| echo "::warning::validate.sh skip validating utilities bundle for non-spark2.4 & non-spark3.1 build" | ||
| echo "::warning::validate.sh validating utilities bundle" | ||
| test_utilities_bundle $JARS_DIR/utilities.jar |
There was a problem hiding this comment.
In the following, we do test on utilities-slim.jar. So we should just remove this check since spark <= 3.1 is not supported (is this true?). We could leave it if not necessarily.
There was a problem hiding this comment.
We want to test that the non-slim bundle isn't missing anything
There was a problem hiding this comment.
since spark < 3.1 is not maintained, should we remove this bundle as well?
linliu-code
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
utilities bundle validation was only happening for spark 2.4 and 3.1 but since we got rid of those, it has not been happening for any spark versions
Impact
more ci testing
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist