Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some clippy errors & add clippy.toml #658

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #647

Rationale for this change

Check #647

What changes are included in this PR?

  • Fix the clippy warnings that are ignored before.
  • Adjust the threshold for the rule result_large_err, and maybe we should handle the large result problem.

Are there any user-facing changes?

None.

How does this change test

Clippy will check it.

@chunshao90
Copy link
Contributor

LGTM

@chunshao90 chunshao90 enabled auto-merge February 21, 2023 08:58
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 added this pull request to the merge queue Feb 21, 2023
Merged via the queue into apache:main with commit ce9fa87 Feb 21, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: fix some clippy errors & add clippy.toml

* chore: add newline for clippy.toml
@ShiKaiWi ShiKaiWi deleted the feat-renable-clippy-rules branch May 29, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable some clippy rules
2 participants