refactor: use enum instead of version for encoding format in pb #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
added
A-analytic-engine
ShiKaiWi
force-pushed
the
fix-encode-default-values
branch
from
e21f7e6 to
49eb4c5
Compare
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
==========================================
+ Coverage 66.84% 66.94% +0.10%
==========================================
Files 283 283
Lines 44006 43969 -37
==========================================
+ Hits 29414 29437 +23
+ Misses 14592 14532 -60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…he#655) * refactor: use enum instead of version for encoding format in pb * fix ut * update package fs_extra to resolve incompact issue reported by cargo * remove wrong exmaple config * fix integration test * rename 'type' of cluster deployment to 'mode' * rename wal_storage to wal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Currently,
versionnumber has been introduced to record the encoding format in the protobuf, and this is very messy compared withenum(one_ofin the protobuf).What changes are included in this PR?
Adapt to apache/incubator-horaedb-proto#51
Are there any user-facing changes?
None.
How does this change test
Existing tests.