Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sql identifier default to case-sensitive #641

Merged
merged 11 commits into from
Feb 15, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Feb 14, 2023

Which issue does this PR close?

Closes #442

Rationale for this change

What changes are included in this PR?

Main code changes are:

  • Build SqlToRel with enable_ident_normalization: false option
  • Build TableReference from ResolvedTableReference

Other changes are clippy fix.

Are there any user-facing changes?

No

How does this change test

integration tests

@codecov-commenter
Copy link

Codecov Report

Merging #641 (7ffb510) into main (d906f9f) will increase coverage by 0.06%.
The diff coverage is 31.18%.

❗ Current head 7ffb510 differs from pull request most recent head 681acb8. Consider uploading reports for the commit 681acb8 to get more accurate results

@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   66.44%   66.50%   +0.06%     
==========================================
  Files         283      283              
  Lines       44286    44235      -51     
==========================================
- Hits        29424    29418       -6     
+ Misses      14862    14817      -45     
Impacted Files Coverage Δ
analytic_engine/src/instance/flush_compaction.rs 66.66% <0.00%> (+0.04%) ⬆️
analytic_engine/src/sampler.rs 99.33% <0.00%> (ø)
analytic_engine/src/setup.rs 55.94% <0.00%> (+0.17%) ⬆️
analytic_engine/src/sst/file.rs 77.17% <ø> (+1.00%) ⬆️
analytic_engine/src/sst/parquet/async_reader.rs 89.59% <0.00%> (+0.45%) ⬆️
catalog_impls/src/table_based.rs 83.79% <0.00%> (+0.20%) ⬆️
catalog_impls/src/volatile.rs 0.00% <0.00%> (ø)
cluster/src/shard_tables_cache.rs 0.00% <0.00%> (ø)
common_types/src/datum.rs 50.69% <0.00%> (ø)
common_util/src/avro.rs 5.76% <0.00%> (+0.09%) ⬆️
... and 87 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Makefile Show resolved Hide resolved
@jiacai2050 jiacai2050 changed the title fix: sql ident default to case-sensitive fix: sql identifier default to case-sensitive Feb 14, 2023
@jiacai2050 jiacai2050 marked this pull request as ready for review February 15, 2023 00:43
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Feb 15, 2023
Merged via the queue into apache:main with commit 2c748bd Feb 15, 2023
@jiacai2050 jiacai2050 deleted the fix-ident-case branch February 21, 2023 08:22
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* bump datafusion

* fix breaking changes

* fix cow errors

* fix error convert

* fix clippy

* fix clippy again

* auto fix

* create SqlToRel with false ident

* fix table reference

* fix rust client

* fix fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identifiers should be case-sensitive for all protocols by default
3 participants