Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support request context #636

Merged
merged 8 commits into from
Feb 13, 2023
Merged

Conversation

jiacai2050
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Adopt with latest protobuf

What changes are included in this PR?

  • Extract schema from database field in request context

Are there any user-facing changes?

Yes, SDK will pass request context

How does this change test

CI

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #636 (c232fbf) into main (2819d5e) will increase coverage by 0.02%.
The diff coverage is 10.00%.

❗ Current head c232fbf differs from pull request most recent head de34a23. Consider uploading reports for the commit de34a23 to get more accurate results

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   66.41%   66.43%   +0.02%     
==========================================
  Files         283      283              
  Lines       44257    44248       -9     
==========================================
+ Hits        29393    29398       +5     
+ Misses      14864    14850      -14     
Impacted Files Coverage Δ
server/src/grpc/storage_service/mod.rs 42.95% <0.00%> (+0.75%) ⬆️
server/src/grpc/storage_service/prom_query.rs 54.42% <ø> (ø)
server/src/grpc/storage_service/write.rs 38.72% <0.00%> (-0.07%) ⬇️
server/src/handlers/prom.rs 68.44% <0.00%> (+0.33%) ⬆️
sql/src/frontend.rs 0.00% <ø> (ø)
server/src/grpc/forward.rs 79.63% <100.00%> (+0.14%) ⬆️
analytic_engine/src/instance/write_worker.rs 72.01% <0.00%> (+0.19%) ⬆️
analytic_engine/src/manifest/details.rs 97.51% <0.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jiacai2050 jiacai2050 changed the title feat: support new request context feat: support request context Feb 10, 2023
server/src/grpc/storage_service/mod.rs Outdated Show resolved Hide resolved
integration_tests/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Feb 13, 2023
Merged via the queue into apache:main with commit d906f9f Feb 13, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: support new request context

* fix clippy

* fix message

* fix wong wal location

* remove schema from route trait

* fix clippy

* make CI happy

* refactor by CR

---------

Co-authored-by: chunshao.rcs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants