feat: convert table names to lowercase #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
convert-metrics-to-lowercase-in-router
branch
from
06cb112 to
6463f3b
Compare
Rachelint
changed the title
Rachelint
changed the title
ShiKaiWi
reviewed
Dec 6, 2022
| @@ -13,11 +18,61 @@ pub async fn handle_route<Q>( | |||
| ctx: &HandlerContext<'_, Q>, | |||
| req: RouteRequest, | |||
| ) -> Result<RouteResponse> { | |||
| // TODO: the case sensitive mode with quoted is not supported now, all table | |||
There was a problem hiding this comment.
Maybe we should file a new issue to track the changes about the case sensitivity. As for this PR, maybe we need a configuration option called case-insensitive = true to enable such conversion.
BTW, in the future changes, I am in favor of that CeresDB may be case-sensitive by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #442
Rationale for this change
Convert all table name to lowercase to unify the behavior.
What changes are included in this PR?
As mentioned in title.
Are there any user-facing changes?
When user uses sdk to interact with ceresdb, the unquoted table name will be converted to lowercase now.
How does this change test
Test manually.