Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add more macro in config #1619

Merged
merged 3 commits into from
Dec 25, 2024
Merged

refactor: add more macro in config #1619

merged 3 commits into from
Dec 25, 2024

Conversation

baojinri
Copy link
Contributor

@baojinri baojinri commented Dec 25, 2024 •
edited
Loading

Rationale

Detailed Changes

  • add Clone & PartialEq in config
  • use ReadableDuration & ReadableSize

Test Plan

CI

@github-actions github-actions bot added the bug Something isn't working label Dec 25, 2024
@baojinri baojinri changed the title fix: add more macro in config refactor: add more macro in config Dec 25, 2024
@baojinri baojinri removed the bug Something isn't working label Dec 25, 2024
@jiacai2050 jiacai2050 self-requested a review December 25, 2024 08:12
jiacai2050
jiacai2050 approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baojinri baojinri merged commit 4d3bb1c into apache:main Dec 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baojinri @jiacai2050