-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: another format for manifest #1604
Merged
jiacai2050
merged 6 commits into
apache:main
from
zealchen:feat_another_manifest_format
Dec 12, 2024
Merged
feat: another format for manifest #1604
jiacai2050
merged 6 commits into
apache:main
from
zealchen:feat_another_manifest_format
Dec 12, 2024
+435
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Dec 10, 2024
jiacai2050
reviewed
Dec 10, 2024
jiacai2050
reviewed
Dec 10, 2024
jiacai2050
reviewed
Dec 10, 2024
jiacai2050
reviewed
Dec 10, 2024
jiacai2050
requested changes
Dec 10, 2024
jiacai2050
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #1600
Detailed Changes
Creating a new data format to represent the manifest snapshot file.
In do_merge, the snapshot data handle is like:
Specifically, I create the SnapshotHeader and SnapshotRecordV1 to represent the corresponding data in snapshot bytes. Before merging delta sstfiles into new bytes, we allocate a larger Vec
<u8>
and copy each segment (header, old records, new records) into it.This RP DOES NOT address format upgrade logic which can be resolved in a separate PR. As for the upgrade, we could define a new SnapshotRecord format and perform data migration in Manifest::try_new.
Test Plan
UT