feat: support pick ssts in compact #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
requested changes
Dec 10, 2024
| for key in all_keys.into_iter().rev() { | ||
| if let Some(bucket) = buckets.get(key) { | ||
| if bucket.len() >= 2 { | ||
| compact_files = bucket.clone(); |
There was a problem hiding this comment.
We need to limit input compact files, also we should compact smaller files first.
There was a problem hiding this comment.
We a SST is picked, we should mark it in compacting, so it won't got compacted twice.
horaedb/metric_engine/src/sst.rs
Outdated
Comment on lines
78
to
80
| pub fn is_uncompacted(&self) -> bool { | ||
| !self.inner.in_compaction.load(Ordering::Relaxed) | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub fn is_uncompacted(&self) -> bool { | |
| !self.inner.in_compaction.load(Ordering::Relaxed) | |
| } | |
| pub fn is_compaction(&self) -> bool { | |
| self.inner.in_compaction.load(Ordering::Relaxed) | |
| } |
Negate this bool inside this function is not very readable.
|
|
||
| let bucket_files = buckets.entry(left).or_default(); | ||
|
|
||
| bucket_files.push(f.id()); |
There was a problem hiding this comment.
FileId is not suitable here, we need to mutate sst inner state, so a Task should hold SstFile
| buckets | ||
| } | ||
|
|
||
| fn get_window_bounds(&self, ts: Timestamp) -> (i64, i64) { |
There was a problem hiding this comment.
Add UT for this function.
baojinri
force-pushed
the
feat-support-pick-ssts
branch
from
f579c45 to
ef04238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Implement pick_candidate for compaction
Detailed Changes
Test Plan
UT