feat: init compact scheduler #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
feat-compact
branch
from
a2b1152 to
b5c2c66
Compare
jiacai2050
force-pushed
the
feat-compact
branch
from
80cf95d to
ecc2a17
Compare
baojinri
reviewed
Nov 29, 2024
| store.clone(), | ||
| segment_duration, | ||
| sst_path_gen.clone(), | ||
| SchedulerConfig::default(), |
There was a problem hiding this comment.
add SchedulerConfig to storage_opts
baojinri
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Setup the basic structure for compaction
Detailed Changes
Test Plan
Old CI, not scheduler has no tests now.