Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add integration test for compaction offload #1573

Merged
merged 11 commits into from
Oct 30, 2024
Merged

test: add integration test for compaction offload #1573

merged 11 commits into from
Oct 30, 2024

Conversation

LeslieKid
Copy link
Contributor

@LeslieKid LeslieKid commented Sep 25, 2024 •
edited
Loading

Rationale

Close #1571

Detailed Changes

  • Impl compact as pre-command for sqlness, with http compaction service.
  • update integration tests to test compaction offload.

Test Plan

@LeslieKid
Copy link
Contributor Author

This pr should be merged after #1563 , it involves testing compaction offload.

@LeslieKid LeslieKid mentioned this pull request Sep 25, 2024
Open
3 tasks
@Rachelint
Copy link
Contributor

For simplificity, I think we can just setup a standalone horaedb in test which acts as both remote compaction caller and remote compaction server?

Rachelint
Rachelint reviewed Sep 30, 2024
View reviewed changes
integration_tests/cases/common/compact/compact.sql Outdated Show resolved Hide resolved
integration_tests/config/horaedb-cluster-0.toml Outdated Show resolved Hide resolved
src/server/src/http.rs Show resolved Hide resolved
@LeslieKid LeslieKid changed the title test: add integration test for compaction test: add integration test for compaction offload Oct 3, 2024
@LeslieKid LeslieKid mentioned this pull request Oct 3, 2024
Closed
Rachelint
Rachelint approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 63c4e9b into apache:main Oct 30, 2024
10 checks passed
@jiacai2050 jiacai2050 mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test for compaction offload
2 participants
@LeslieKid @Rachelint