Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove i18n for hop-conf project options. fixes #4216 #4223

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

bamaer
Copy link
Contributor

@bamaer bamaer commented Aug 19, 2024

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@hansva
Copy link
Contributor

hansva commented Aug 19, 2024

Keys should be removed from the translation files to keep everything clean.

@bamaer
Copy link
Contributor Author

bamaer commented Aug 20, 2024

the same keys are used in the project and other dialogs in Hop Gui, so these can't be removed.

@hansva hansva merged commit 3042abd into apache:main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants