Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http authentication with proxy #4214

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

rramthun
Copy link

*) fixes #4195
*) resolve discrepancies between Hop documentation and behaviour w.r.t. empty/null usernames and password in case of HTTP basic auth


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@rramthun
Copy link
Author

@hansva do you have any questions or wishes for changes w.r.t. this pull request?

@hansva
Copy link
Contributor

hansva commented Aug 22, 2024

@rramthun It looks good on first sight, just haven't had the time to test yet. Will get to it shortly.

@hansva
Copy link
Contributor

hansva commented Aug 26, 2024

Thanks for the work @rramthun !

@hansva hansva merged commit 3febce6 into apache:main Aug 26, 2024
3 checks passed
@rramthun rramthun deleted the fix-http-auth-with-proxy branch September 3, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: REST transformer: HTTP authentication not working with proxy
2 participants