Attempt to make the POM, assemblies and dependencies more structured #4114 #4168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes almost all Assembly files and simplifies the build process.
Note: you have to remove the unused folders from /assemblies else the client will contain the plugins twice (it will fetch the zips from target not sure why... but does not happen with a clean install)
All shared libraries that end up in lib/core are specified under /lib but each plugin will add their own jars to lib/core.
This allows us to create a hop version with only the dependencies needed for the selected plugins while still using globally shared versions
hop-engine-beam now contains the minimal set of dependencies needed for to make hop work without the Beam plugin
The Beam plugin has been moved to lib/beam future step would be to split this further down to the specific runners
Each plugin zip is now build from the root directory so they can add files to lib/core and the samples are contained within the plugin zip during build time
Tried to simplify the assembly files by fetching all runtime dependencies in stead of manually listing the jars
This did not fully work as planned because of maven limitations eg this three gives issues:
Provided does not traverse to transient dependencies (which I would have expected it did)
${beam.version}
is usedThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:check
to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i
.addresses #123
), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.