Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote run configuration refers to itself #3935 #3962

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

nadment
Copy link
Contributor

@nadment nadment commented May 22, 2024

Stop execution with an error and provide an explanation

@hansva
Copy link
Contributor

hansva commented May 24, 2024

this is a great first step, but shouldn't we load the linked configuration to see if that one then doesn't target one of the already used configurations. I know this isn't used often but someone could make remote 1 -> remote 2 -> remote 1and that wouldn't be detected this way

@nadment
Copy link
Contributor Author

nadment commented May 25, 2024

That's a bit of a twisted scenario, and in that case are all the RemoteRunConfiguration metadata accessible from the starting point?

@hansva
Copy link
Contributor

hansva commented May 25, 2024

You are right, let's just fix this if the other one ever pops up we will see then

@hansva hansva merged commit e720437 into apache:main May 25, 2024
2 checks passed
@github-actions github-actions bot removed this from the 2.10 milestone May 25, 2024
@nadment nadment deleted the 3935 branch May 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Workflow engine type "Hop remote workflow engine" can reference itself
2 participants