Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Excel Transform to allow streaming where a template is used #2896

Merged
merged 1 commit into from
May 13, 2023

Conversation

dameikle
Copy link
Member

@dameikle dameikle commented May 3, 2023

When using the Excel Transform in streaming mode (i.e. XLSX and using SXSSF in POI) to handling the generation of large Excel documents, where we used a template the transformation would always use XSSF and fail.

This update allows streaming to happen where a template is used though has all the limitations of POI in this mode so is ideal for adding new content to a template, and not for amending existing content.

Given this is a change in behaviour from before which silently fellback to XSSF mode, was debating logging an info message on this but didn't as the transform would fail.


@hansva
Copy link
Contributor

hansva commented May 13, 2023

Thanks for the contribution @dameikle , sorry about the delay for the merge!

@hansva hansva merged commit 89ba7e3 into apache:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants